Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another .38 special clean up / balance #852

Merged
merged 18 commits into from
Mar 7, 2024
Merged

Another .38 special clean up / balance #852

merged 18 commits into from
Mar 7, 2024

Conversation

FluffiestFloof
Copy link
Contributor

@FluffiestFloof FluffiestFloof commented Feb 18, 2024 •
edited
Loading

Hey it's only the fifth PR related to the least used ammo type but I originally PR'd those so I get to keep maintaining them :trollface:

About the PR

  • Added the 'Lucky 37' to the salvage loot pool alongside the other revolvers. Might aswell, that was the original plan for it.
  • Updated old DeltaV markers that relates to .38 special to the new one.
  • Added Incendiary and Uranium .38 ammo + ammo boxes to match the other ammo types.
  • Added Mindbreaker ammo box and speedloader
  • Updated lathe recipes to make slightly more sense and follow the same logic as magnum ammo (even if weird, printing ammo boxes is always more cost efficient)
  • Reduced stamina damage of the rubber ammo from 35 to 30
  • Nerfed Psi-Breaker firerate from 4 to 3.5 (woah big difference)
  • Buffed the revolver firerates to be more in line with the other revolvers.
  • Updated the speedloader sprites to match the other revolver ones
  • Updated the psibreaker sprite because the ejection port was annoying me
  • Updated holy damage to actually not be worse than normal bullets (18 Piercing + 6 holy) aka a total of 38 damage if they are 3x vulnerable to holy

Why / Balance

This was due for a little clean up + balance check imo.

Technical details

Media

  • I have not added screenshots/videos to this PR showcasing its changes ingame because I'm lazy just look at the sprite bot and yaml

Breaking changes

Changelog

Mostly background stuff

@FluffiestFloof
Fix weird firerates
e8218dc 
The .45 magnum firerate is around 2 to 3 so it was extremely funny how the .38 would be slower than a .45 and even the snubbed version.
@FluffiestFloof
change ejection port placement on psibreaker
180d31c
@FluffiestFloof
Rubber nerf + new ammo + fix recipe costs
825d2ec 
Everyone gets incendiary and uranium bullets so why not.
@FluffiestFloof
Make lucky available in salvage
a698516 
Alongside the other revolvers
@FluffiestFloof
Update look of speedloader
6c296d8 
So it matches the other revolver speedloader. Slightly smaller just because.
@FluffiestFloof
Fix mistakes 🍞
4eaa0a1
@FluffiestFloof
Add extra speedloaders
74a469f
@FluffiestFloof
mindbreaker ammo box
977bce1
@FluffiestFloof
New markers, update old .38 markers
be41b0a
@FluffiestFloof
commentfix
0a18956
@FluffiestFloof
firerate pass 2
8ede955
@FluffiestFloof
Fixes
73e1fbf
@github-actions github-actions bot added Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Feb 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2024 •
edited
Loading

RSI Diff Bot; head commit 6aa1324 merging into b0c9f56
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Guns/Ammunition/SpeedLoaders/Special/special_speed_loader.rsi

State Old New Status
base-1 Modified
base-2 Modified
base-3 Modified
base-4 Modified
base-5 Modified
base-6 Modified
base Modified
practice-1 Modified
practice-2 Modified
practice-3 Modified
practice-4 Modified
practice-5 Modified
practice-6 Modified
rubber-1 Modified
rubber-2 Modified
rubber-3 Modified
rubber-4 Modified
rubber-5 Modified
rubber-6 Modified
high-velocity-1 Removed
high-velocity-2 Removed
high-velocity-3 Removed
high-velocity-4 Removed
high-velocity-5 Removed
high-velocity-6 Removed
holy-1 Added
holy-2 Added
holy-3 Added
holy-4 Added
holy-5 Added
holy-6 Added
icon Added
mindbreaker-1 Added
mindbreaker-2 Added
mindbreaker-3 Added
mindbreaker-4 Added
mindbreaker-5 Added
mindbreaker-6 Added
uranium-1 Added
uranium-2 Added
uranium-3 Added
uranium-4 Added
uranium-5 Added
uranium-6 Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Pistols/psibreaker.rsi

State Old New Status
base Modified
bolt-open Modified
icon Modified

Resources/Textures/DeltaV/Objects/Weapons/Guns/Ammunition/Boxes/special.rsi

State Old New Status
incendiary Added
mindbreaker Added
uranium Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Ammunition/Magazine/Pistol/pistol_special_mag.rsi

State Old New Status
uranium Added

Edit: diff updated after 6aa1324

@FluffiestFloof FluffiestFloof marked this pull request as ready for review February 19, 2024 19:41
VMSolidus
VMSolidus previously approved these changes Feb 24, 2024
View reviewed changes
@FluffiestFloof
holy update after someone pointed out the damage
2cb4849 
It's technically still a bullet but coated in silver/holy magic whatever, so it should still pierce. Still have to print them one by one and they are not as good as normal bullet against normal things
@DebugOk
Copy link
Contributor

DebugOk commented Mar 7, 2024 •
edited
Loading

66 changes files
VMSolidus previously approved these changes 2 weeks ago

Lgtm

@DebugOk DebugOk merged commit 5ac3da2 into DeltaV-Station:master Mar 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus left review comments

@DebugOk DebugOk Awaiting requested review from DebugOk

Assignees
No one assigned
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FluffiestFloof @DebugOk @VMSolidus